Merged
Conversation
Member
Since for descriptors we turn a struct into flat args, it makes sense (I think) to unify them. I'm not sure if I was myself explicitly aware of how it works:
|
almarklein
approved these changes
Apr 13, 2026
Member
almarklein
left a comment
almarklein
left a comment
There was a problem hiding this comment.
Nice work, big improvement! I made some small tweaks to make the difference more explicit, and force Attribute to be instantiated with a source param.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #803
I think this is a fix, but it is pretty awkward. The parsing logic for
Attributesimply couldn't really distinguish between struct field (dict members) and positional args for a function. because the required <-> optional logic is different between the two.Maybe there should be another class for
Parameterinstead?I didn't check if any of the implementations of the native api need fixes, because some seem to validate defaults twice already example while the vast majority simply never handled an incorrectly passed
None.Python still won't necessarily raise anything more useful and the error comes from the native layer, unless you enforce typing.